Draft: Android CI production build and Play Store auto-submission #3392

pljones · 2024-10-02T15:01:32Z

Short description of changes

Revival of #2909

The primary goal of the patch was to enable Google Play Store automated uploads as part of the GitHub build process.

CHANGELOG: DO NOT MERGE

Context: Fixes an issue?

The patch not only adopts the new action (r0adkll/upload-google-play@v1) but changes dependencies:

Variable	from	to
`COMMANDLINETOOLS_VERSION`	6858069	7.0
`ANDROID_NDK_VERSION`	r21d	25.1.8937393
`ANDROID_PLATFORM`	android-30	android-33
`ANDROID_BUILD_TOOLS`	30.0.2	33.0.0
`AQTINSTALL_VERSION`	3.1.18	2.1.0
`QT_VERSION`	5.15.2	6.3.2

As a side effect, it enables the Jamulus.pro to build on Windows by removing the Linux dependency (or at least side-stepping it).

Code changes are a side effect of the move to Qt6 (but I think probably work in Qt5.15.2, too, so could be trialled).

Does this change need documentation? What needs to be documented and how?

We should add documentation about the build process somewhere but that's not part of this ticket. Unless it already exists and needs changing.

Status of this Pull Request

Proof of concept (not to be merged soon).

What is missing until this pull request can be merged?

Decide if we do this in r4.0 rather than r3.12.0.
Someone who knows the build chain needs to review it.
We need to understand the proposed Github action and agree it's acceptable (and choose a version to pin).
The updated dependencies need to be understood, including their effect on the supported Android versions and how that affects Jamulus documentation.

Checklist

I've verified that this Pull Request follows the general code principles
I tested my code and it does what I want
My code follows the style guide
I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
I've filled all the content above

pljones · 2024-10-02T15:03:11Z

.github/autobuild/android.sh

-        rm -r "${QT_BASEDIR}/${QT_VERSION}/android/qml/"
+        # icu needs explicit installation
+        # otherwise: "qmake: error while loading shared libraries: libicui18n.so.56: cannot open shared object file: No such file or directory"
+        python3 -m aqt install-qt --outputdir "${QT_BASEDIR}" linux desktop "${QT_VERSION}" \


New dependencies need documenting.

pljones · 2024-10-02T15:04:15Z

.github/workflows/autobuild.yml

+                                    needs.create_release.outputs.publish_to_release == 'true' &&
+                                    matrix.config.target_os == 'android'
+        id:                         publish_android
+        uses:                       r0adkll/upload-google-play@v1


We need to review this action and confirm it's okay.

I would rather check if it's possible like for iOS to use native cli tools or an official action by google.

pljones · 2024-10-02T15:05:27Z

Jamulus.pro

+    # ANDROID_ABIS = armeabi-v7a arm64-v8a x86 x86_64
+
+    # get ANDROID_ABIS from environment - passed directly to qmake
+    ANDROID_ABIS = $$getenv(ANDROID_ABIS)


From where will these come when running make distclean; qmake ...?

There should be a set of defaults that can be overridden from the build chain.

pljones · 2024-10-02T15:05:58Z

Jamulus.pro

    ANDROID_VERSION_NAME = $$VERSION
-    ANDROID_VERSION_CODE = $$system(git log --oneline | wc -l)


This should default to 1 and the build chain should pass the correct value:

1 for anything but a release build (as we will not publish to Google Store anything but release builds).

retrieve last_release_android_version from permanent storage, add the number of ABI builds to be released plus one, store that in last_release_android_version permanent storage and pass it to the build.

pljones · 2024-10-02T15:06:19Z

Jamulus.pro

+        ANDROID_VERSION_CODE = 1234 # dummy int value
+    } else {
+        # date-based unique integer value for Play Store submission
+        !defined(ANDROID_VERSION_CODE, var):ANDROID_VERSION_CODE = $$system(date +%s | cut -c 2-)


See above - I'd rather remove this entirely and default to 1 and use the

ANDROID_VERSION_CODE = $$num_add($$ANDROID_VERSION_CODE, ...)

approach.

pljones · 2024-10-02T15:06:40Z

Jamulus.pro


    # enabled only for debugging on android devices
-    DEFINES += ANDROIDDEBUG
+    #DEFINES += ANDROIDDEBUG


Are we sure we want to remove this?

pljones · 2024-10-02T15:07:26Z

src/main.cpp

@@ -40,7 +40,7 @@
 #endif
 #include "util.h"
 #ifdef ANDROID
-#    include <QtAndroidExtras/QtAndroid>
+#    include <QtCore/private/qandroidextras_p.h>


QtCore/private/qandroidextras_p.h I'd rather not be including "private" header files. There is a standardised Qt6 permissions API, as far as I know -- if we're using Qt6, we should make all the necessary changes not hack the code...

So this is a blocker we'll need to address if Qt6 is required for Google Store.

pljones · 2024-10-02T15:08:13Z

The main issue is the move to Qt6. I think that should be addressed separately. If this change requires Qt6, then it gets blocked until we've made the decision to move Android to Qt6 and made the necessary code changes correctly.

ann0see · 2024-10-31T21:41:27Z

I can only test this on a PC with bliss os. It would be interesting to see if the qt6 build shows the same UI overflow issues as iOS

ann0see · 2024-10-31T21:43:24Z

.github/autobuild/android.sh

        setup_qt
        ;;
    build)
-        build_app_as_apk
+        # Build all targets in sequence
+        build_app "android_armv7"


It would be neat to parallelize builds of possible. Android takes ages already.

* android build conf changes * fix shellcheck warnings android fix audio permission handling android fix androidextras include android remove redundant jdk install add ANDROID_NDK_ROOT comment fix for clang-format style check android add all ABI support android: remove redundant minSdkVersion clang-format fixes android: fix manifest xml, remove old boilerplate add ANDROID_SDK_ROOT shellcheck fix android fix assignments in pro file fix typo

pljones commented Oct 2, 2024

View reviewed changes

ann0see reviewed Oct 31, 2024

View reviewed changes

pljones added feature request Feature request android Android runtime issue release process Changes to the release process labels Nov 24, 2024

pljones force-pushed the feature/danryu/submit-to-Google-Play-Store branch from 12631a1 to aded45d Compare December 10, 2024 18:34

ann0see mentioned this pull request Dec 11, 2024

Target Android 14 (SDK 34) #3437

Closed

5 tasks

pljones added this to the Release 4.0.0 milestone Dec 12, 2024

pljones mentioned this pull request Dec 12, 2024

Jamlus not supporting android target version 34 #3261

Open

pljones linked an issue Dec 12, 2024 that may be closed by this pull request

Jamlus not supporting android target version 34 #3261

Open

pljones force-pushed the feature/danryu/submit-to-Google-Play-Store branch from aded45d to 0f08516 Compare December 18, 2024 13:40

danryu and others added 2 commits December 20, 2024 17:00

Document feature branch

3ef15a2

pljones force-pushed the feature/danryu/submit-to-Google-Play-Store branch from 0f08516 to 3ef15a2 Compare December 20, 2024 17:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Draft: Android CI production build and Play Store auto-submission #3392

Draft: Android CI production build and Play Store auto-submission #3392

pljones commented Oct 2, 2024

pljones Oct 2, 2024

pljones Oct 2, 2024

ann0see Oct 2, 2024

pljones Oct 2, 2024

pljones Oct 2, 2024

pljones Oct 2, 2024

pljones Oct 2, 2024

pljones Oct 2, 2024

pljones commented Oct 2, 2024

ann0see commented Oct 31, 2024

ann0see Oct 31, 2024

		ANDROID_VERSION_NAME = $$VERSION
		ANDROID_VERSION_CODE = $$system(git log --oneline \| wc -l)

Draft: Android CI production build and Play Store auto-submission #3392

Are you sure you want to change the base?

Draft: Android CI production build and Play Store auto-submission #3392

Conversation

pljones commented Oct 2, 2024

Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pljones commented Oct 2, 2024

ann0see commented Oct 31, 2024

Choose a reason for hiding this comment